Use ENOMEM return and add goto out on AAD error with linuxkm#9971
Use ENOMEM return and add goto out on AAD error with linuxkm#9971douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns kernel-module error handling with platform conventions by returning -ENOMEM on allocation failures and ensuring early exit/cleanup when AAD processing fails.
Changes:
- Replace
-MEMORY_Ewith-ENOMEMfor allocation failures in Linux KM AES init paths. - Add
gototo a common exit path on AAD error in GCM work handling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| linuxkm/lkcapi_aes_glue.c | Switch allocation-failure returns to Linux-standard -ENOMEM. |
| bsdkm/wolfkmod.c | Jump to shared cleanup/exit path when AAD setup reports an error. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
Retest this please Jenkins. Windows test connection failure. |
|
Retest this please Jenkins. Multi-test failure |
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
tested with
wolfssl-multi-test.sh ...
quantum-safe-wolfssl-all-crypto-only-intelasm-linuxkm-mainline-insmod
'.*cust-kernel-3.*'
|
note, Jenkins failure was |
f-631 & f-669